Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for enums in python 3.10 #425

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

WilliamJamieson
Copy link
Collaborator

Closes #424

This PR fixes and odd bug found for python 3.10 in romancal. See #424 for more details.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner November 12, 2024 16:36
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (087a60d) to head (8793f2d).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   97.56%   97.42%   -0.14%     
==========================================
  Files          30       37       +7     
  Lines        2788     3461     +673     
==========================================
+ Hits         2720     3372     +652     
- Misses         68       89      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson
Copy link
Collaborator Author

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks William, looks good, approving.

@WilliamJamieson WilliamJamieson merged commit 11c731a into spacetelescope:main Nov 12, 2024
17 of 18 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/enum_310 branch November 12, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failures "TypeError: <group.GOOD: np.uint32(0)> cannot be pickled"
2 participants