Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default constructor to datamodels and deprecate the maker_utils #436

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Deprecate the maker utils

890385e
Select commit
Loading
Failed to load commit list.
Draft

Add default constructor to datamodels and deprecate the maker_utils #436

Deprecate the maker utils
890385e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 27, 2024 in 1s

97.28% (-0.29%) compared to 087a60d

View this Pull Request on Codecov

97.28% (-0.29%) compared to 087a60d

Details

Codecov Report

Attention: Patch coverage is 96.26866% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (087a60d) to head (890385e).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/roman_datamodels/maker_utils.py 0.00% 4 Missing ⚠️
src/roman_datamodels/datamodels/_core.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   97.56%   97.28%   -0.29%     
==========================================
  Files          30       38       +8     
  Lines        2788     3420     +632     
==========================================
+ Hits         2720     3327     +607     
- Misses         68       93      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.