Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some support for opening SSC models #448

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jan 8, 2025

Resolves RCAL-976

Closes #

This PR adds limited support for opening SSC derived asdf files using rdm_open .This is not perfect because there is not an easy way to identify if a model is one of the SSC ones from roman_gdps right now.

Tasks

  • Update or add relevant roman_datamodels tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner January 8, 2025 17:43
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.36%. Comparing base (087a60d) to head (b68f3d7).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
src/roman_datamodels/datamodels/_utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   97.56%   97.36%   -0.20%     
==========================================
  Files          30       36       +6     
  Lines        2788     3301     +513     
==========================================
+ Hits         2720     3214     +494     
- Misses         68       87      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamJamieson WilliamJamieson merged commit 506b979 into spacetelescope:main Jan 10, 2025
17 of 19 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/open_ssc branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants