Skip to content

Commit

Permalink
Update regtest code for DMS 392, DMS394, DMS395. (#1594)
Browse files Browse the repository at this point in the history
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
2 people authored and stscieisenhamer committed Feb 5, 2025
1 parent 497f7e6 commit 3a4737c
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
15 changes: 14 additions & 1 deletion romancal/regtest/test_multiband_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@
"F158_aper_total_flux", # DMS375 fluxes
"F158_aper_total_flux_err", # DMS386 flux uncertainties
"flags", # DMS387 dq_flags
"is_extended", # DMS392 source classification
"semimajor_sigma", # DMS394 galaxy morphology
"semiminor_sigma", # DMS394 galaxy morphology
"orientation", # DMS394 galaxy morphology
"F158_isophotal_flux_err", # DMS395 basic statistical uncertainties
"F158_kron_flux_err", # DMS395 basic statistical uncertainties
"F158_aper30_flux_err", # DMS395 basic statistical uncertainties
"F158_x_psf_err", # DMS395 basic statistical uncertainties
]


Expand Down Expand Up @@ -45,6 +53,12 @@ def test_multiband_catalog(rtdata_module):
for field in fieldlist:
assert field in afcat["roman"]["source_catalog"].dtype.names

step = MultibandCatalogStep()
step.log.info(
"DMS374, 399, 375, 386, 387, 392, 394, 395: source catalog includes fields: "
+ ", ".join(fieldlist)
)

# DMS 393: multiband catalog uses both PSF-like and extend-source-like
# kernels
assert set(aftruth["roman"]["source_catalog"].dtype.names) == set(
Expand All @@ -56,7 +70,6 @@ def test_multiband_catalog(rtdata_module):
# the same, but we can easily check that the columns match up
# by name.

step = MultibandCatalogStep()
step.log.info("DMS391: successfully used multiple kernels to detect sources.")
step.log.info("DMS393: successfully used deblending to separate blended sources.")
step.log.info(
Expand Down
9 changes: 9 additions & 0 deletions romancal/tests/dms_requirement_tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,18 @@
"DMS391": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
"DMS392": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
"DMS393": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
"DMS394": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
"DMS395": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
"DMS399": [
"romancal.regtest.test_multiband_catalog.test_multiband_catalog"
],
Expand Down

0 comments on commit 3a4737c

Please sign in to comment.