Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rad-155 #1131

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Rad-155 #1131

merged 6 commits into from
Mar 12, 2024

Conversation

nden
Copy link
Collaborator

@nden nden commented Mar 8, 2024

Resolves RCAL-nnnn

Closes #

This PR makes the changes needed for RAD-155. It depends on

spacetelescope/rad#390
spacetelescope/roman_datamodels#328

Regression tests are run here
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/635/
The one failure is expected and needs an updated truth file.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@nden nden requested a review from a team as a code owner March 8, 2024 14:10
@github-actions github-actions bot added testing dependencies Pull requests that update a dependency file labels Mar 8, 2024
@nden nden added resample outlier_detection and removed dependencies Pull requests that update a dependency file labels Mar 8, 2024
@nden nden added this to the 24Q3_B14 milestone Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.36%. Comparing base (bd465ec) to head (96f59e8).
Report is 2 commits behind head on main.

❗ Current head 96f59e8 differs from pull request most recent head 17c63bd. Consider uploading reports for the commit 17c63bd to get more accurate results

Files Patch % Lines
romancal/resample/resample.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   76.72%   72.36%   -4.36%     
==========================================
  Files         105      105              
  Lines        7054     7053       -1     
==========================================
- Hits         5412     5104     -308     
- Misses       1642     1949     +307     
Flag Coverage Δ *Carryforward flag
nightly 62.73% <ø> (ø) Carriedforward from bd465ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's merge the rad update first so we can point to rad / roman_datamodels / main.

@nden
Copy link
Collaborator Author

nden commented Mar 12, 2024

I think #1128 needs to be merged before this as all errors are related to units.

@schlafly schlafly merged commit 064096a into spacetelescope:main Mar 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants