-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rad-155 #1131
Rad-155 #1131
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
- Coverage 76.72% 72.36% -4.36%
==========================================
Files 105 105
Lines 7054 7053 -1
==========================================
- Hits 5412 5104 -308
- Misses 1642 1949 +307
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Let's merge the rad update first so we can point to rad / roman_datamodels / main.
for more information, see https://pre-commit.ci
I think #1128 needs to be merged before this as all errors are related to units. |
Resolves RCAL-nnnn
Closes #
This PR makes the changes needed for RAD-155. It depends on
spacetelescope/rad#390
spacetelescope/roman_datamodels#328
Regression tests are run here
https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/635/
The one failure is expected and needs an updated truth file.
Checklist
CHANGES.rst
under the corresponding subsection