Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendorize and fix crds workflow #1467

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 21, 2024

Similar to spacetelescope/jwst#8869

It looks like the roman crds server was just updated to now require a second argument for the curl command leading to failures in the CI on main:
https://github.com/spacetelescope/romancal/actions/runs/11443462254/job/31836161436

This vendorizes the crds contexts workflow and fixes it for the recent change to the roman crds server.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@braingram
Copy link
Collaborator Author

braingram commented Oct 21, 2024

@schlafly this was the crds change I mentioned last week. It looks like it was deployed. This PR should fix the currently failing romancal CI.

@braingram
Copy link
Collaborator Author

Closing and reopening to try to retrigger webbpsf data file download (since that is now failing possibly due to a cache key change with the crds update).

@braingram braingram closed this Oct 21, 2024
@braingram braingram reopened this Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15%. Comparing base (4e55afb) to head (cb93bfd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
- Coverage   78.11%   76.15%   -1.96%     
==========================================
  Files         118      115       -3     
  Lines        7689     7638      -51     
==========================================
- Hits         6006     5817     -189     
- Misses       1683     1821     +138     
Flag Coverage Δ
nightly ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Brett. This looks good to me. This is also the approach you are taking for Webb?

@braingram
Copy link
Collaborator Author

Thanks Brett. This looks good to me. This is also the approach you are taking for Webb?

Thanks! Yeah spacetelescope/jwst#8869 was merged (and gwcs went the same route: spacetelescope/gwcs#518). Eventually it might be easier to consolidate this again but likely using the crds client directly rather than the curl commands as is currently done in the workflow. This PR is more a stop-gap until that work can be considered, prioritized and implemented.

@braingram braingram merged commit 0a530f2 into spacetelescope:main Oct 21, 2024
58 of 65 checks passed
@braingram braingram deleted the fix_crds_workflow branch October 21, 2024 17:39
@braingram
Copy link
Collaborator Author

braingram commented Oct 21, 2024

I should have noted that as this doesn't touch any code or infrastructure related to the regression tests. No regression tests were run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants