-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendorize and fix crds workflow #1467
Conversation
7c9f606
to
cb93bfd
Compare
@schlafly this was the crds change I mentioned last week. It looks like it was deployed. This PR should fix the currently failing romancal CI. |
Closing and reopening to try to retrigger webbpsf data file download (since that is now failing possibly due to a cache key change with the crds update). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 78.11% 76.15% -1.96%
==========================================
Files 118 115 -3
Lines 7689 7638 -51
==========================================
- Hits 6006 5817 -189
- Misses 1683 1821 +138
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Brett. This looks good to me. This is also the approach you are taking for Webb?
Thanks! Yeah spacetelescope/jwst#8869 was merged (and gwcs went the same route: spacetelescope/gwcs#518). Eventually it might be easier to consolidate this again but likely using the |
I should have noted that as this doesn't touch any code or infrastructure related to the regression tests. No regression tests were run. |
Similar to spacetelescope/jwst#8869
It looks like the roman crds server was just updated to now require a second argument for the curl command leading to failures in the CI on main:
https://github.com/spacetelescope/romancal/actions/runs/11443462254/job/31836161436
This vendorizes the crds contexts workflow and fixes it for the recent change to the roman crds server.
Tasks
24Q4_B15
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth filesnews fragment change types...
changes/<PR#>.general.rst
: infrastructure or miscellaneous changechanges/<PR#>.docs.rst
changes/<PR#>.stpipe.rst
changes/<PR#>.associations.rst
changes/<PR#>.scripts.rst
changes/<PR#>.mosaic_pipeline.rst
changes/<PR#>.patch_match.rst
steps
changes/<PR#>.dq_init.rst
changes/<PR#>.saturation.rst
changes/<PR#>.refpix.rst
changes/<PR#>.linearity.rst
changes/<PR#>.dark_current.rst
changes/<PR#>.jump_detection.rst
changes/<PR#>.ramp_fitting.rst
changes/<PR#>.assign_wcs.rst
changes/<PR#>.flatfield.rst
changes/<PR#>.photom.rst
changes/<PR#>.flux.rst
changes/<PR#>.source_detection.rst
changes/<PR#>.tweakreg.rst
changes/<PR#>.skymatch.rst
changes/<PR#>.outlier_detection.rst
changes/<PR#>.resample.rst
changes/<PR#>.source_catalog.rst