Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc small fixes and tweaks #1480

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Misc small fixes and tweaks #1480

wants to merge 2 commits into from

Commits on Oct 30, 2024

  1. Fix reference to np.core

    @WilliamJamieson
    WilliamJamieson committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2f57d67 View commit details
    Browse the repository at this point in the history

  2. Small tweak to test using int.bit_length. 

    It was suggested by numpy devs that we fully commit to using `np.uint32` values for the flags rather than just casting then to those values when assigning into dq array.
The one method numpy integers do not have that python integers do is `bit_length` method (because numpy integers will be fixed bit size given dtype unlike python integers which grow as needed).
Thus we need to cast to python integer first. This will not effect anything right now, but allow us to follow numpy's advice later.
    @WilliamJamieson
    WilliamJamieson committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    cfb97a7 View commit details
    Browse the repository at this point in the history