AL-852: GWCS should respect the bounding box on inverse transforms #263
+38
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 85.18% 83.87% -1.31%
==========================================
Files 35 35
Lines 6797 6984 +187
==========================================
+ Hits 5790 5858 +68
- Misses 1007 1126 +119 ☔ View full report in Codecov by Sentry. |
src/stcal/alignment/util.py
Outdated
| @@ -269,7 +269,7 @@ def _calculate_new_wcs(ref_model, shape, wcs_list, fiducial, crpix=None, transfo | |||
| ---------- | |||
| ref_model : | |||
| The reference model to be used when extracting metadata. | |||
|
|
|||
| bp | |||
9 tasks
|
@nden Is this something that you want to try to get into the jwst B11.0 release next week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-nnnn
Resolves RCAL-nnnn
Closes #
The GWCS PR is spacetelescope/gwcs#498
The changes here use the WCS API in order to pick up the bounding box.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)