-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests for Network & Storage. And minor improvements #11
Conversation
@vaibhawvipul I would also like to suggest few improvement in this PR. If that sounds fine ? Line 121 in 2b1c74b
And when we delete the file ? Line 102 in 2b1c74b
|
Connection can be closed because of various reasons. Let's say we want to change the port. I still would want to keep the logs because later on I want the server to do catch-up, instead of expecting complete logs from other servers, when it is restarted. Does it make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Partially closes #3
Change List