Allow to parameterize seed value as in original murmur3 implementation #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was implementing this change, I missed that similar work has been done already (#9 and #10), but I figured it's worth sharing.
seed
to every constructor (32-, 64- and 128-bit) as well asSum32
,Sum64
andSum128
Obvious drawback is the API breakage of this lib, so maybe the way to go would be to tag the lib and start versioning (e.g.
0.1
for current, and0.2
for this PR and up)?