Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the layout of anonymous system profile info to align better with the rest of the panel's UI #2564

Merged
merged 1 commit into from
May 21, 2024

Conversation

danielpunkass
Copy link
Contributor

These are minor tweaks to finesse the appearance of the SUUpdatePermissionPrompt when the "Include anonymous system profile" disclosure button is selected.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

I compared the appearance of the panel by forcing "shouldPrompt" to YES and visually examining the resulting panel. I also created comparison images to show the effect of the change both with -NSShowAllViews 1, and without:

BeforeAndAfter

macOS version tested: macOS Sonoma 14.5

@zorgiepoo
Copy link
Member

zorgiepoo commented May 21, 2024

Thanks, a somewhat subtle change. I definitely did change the alignment a bit when I made this window use a stack view in 2.x. I do wonder if there should be a left-padding for the table view, from the explanation text above it. There was padding in 1.x there and I think it was intentional (I didn't design it though), so the table doesn't look like it's too much to the "left" of the explanation text above it. I'm not a pixel/UI expert, though.

@danielpunkass
Copy link
Contributor Author

I imagine there are probably lots of "right" ways to design this, but the thing that looked particularly off to me was that neither the text nor the table view looked indented enough to look intentional. So in the absence of somebody putting the effort in to do a more substantial redesign, I think this is at least a good refinement of the status quo.

@danielpunkass
Copy link
Contributor Author

I think it is common though for table views to be aligned flush with the text above them. Just one example I found by looking in Safari's preferences:
image

@zorgiepoo
Copy link
Member

Fair enough, sounds good, thanks!

@zorgiepoo zorgiepoo merged commit 61054c7 into sparkle-project:2.x May 21, 2024
2 checks passed
@danielpunkass danielpunkass deleted the anonymous-info-ui branch May 21, 2024 03:07
@zorgiepoo zorgiepoo added this to the 2.7 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants