Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Encoding class for xml write_to #2798

Merged
merged 4 commits into from
Mar 7, 2023
Merged

fix: support Encoding class for xml write_to #2798

merged 4 commits into from
Mar 7, 2023

Commits on Mar 6, 2023

  1. test: add encoding coverage for all serialization methods 

    See sparklemotion#2774 and sparklemotion#2798
    @flavorjones
    flavorjones committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2bafd9f View commit details
    Browse the repository at this point in the history

  2. fix(jruby): write_to enc falls back to document encoding 

    This is what libxml2's `xmlsave.c` functions do, so let's make it
explicit in the caller so that JRuby has the same behavior.
    @flavorjones
    flavorjones committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    9dc8c28 View commit details
    Browse the repository at this point in the history

  3. fix: support Encoding class for write_to 

    Co-authored-by: Mike Dalessio <[email protected]>
    @ellaklara @flavorjones
    ellaklara and flavorjones committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    08bc6f9 View commit details
    Browse the repository at this point in the history

  4. doc: update CHANGELOG and Node#write_to docstring

    @flavorjones
    flavorjones committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    81faf60 View commit details
    Browse the repository at this point in the history