Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document official support for the pattern matching API #2967

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Aug 26, 2023

What problem is this PR intended to solve?

Pattern matching was introduced as an experimental feature in v1.14.0 (see #2360 and #2523 for historical context).

Seeing downstream libraries adopt pattern matching for testing, as in rails/rails#49003, means this is apparently useful enough to start using.

Let's end experimental support and make it a fully-supported feature in the next minor release, v1.16.0.

This statement was moved in b910c6a, incorrectly, and as a result the
remaining methods in the file were undocumented.
@flavorjones flavorjones merged commit 47c18ba into main Aug 26, 2023
125 checks passed
@flavorjones flavorjones deleted the flavorjones-official-support-pattern-matching branch August 26, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant