One intermediate screen is present in dev after login, which is not present in figma (present in all the login and sign-up options) #2385 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not present in figma (present in all the login and sign-up options)
Astitva877
reviewed
Jan 15, 2025
Comment on lines
+32
to
+36
| let data = JSON.parse(window.atob(accessToken?.split('.')[1])); | ||
| let firstName = data.name; | ||
| firstName = firstName.split(' ')[0]; | ||
| firstName = firstName.length > 11 ? firstName.substring(0, 5) + "..." : firstName; | ||
| redirectRules.title = `Welcome Back ${firstName}`; |
There was a problem hiding this comment.
place this code inside settimeout, not outside it, like it was before.
Astitva877
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One intermediate screen is present in dev after login, which is not present in figma (present in all the login and sign-up options)
#2385
1.Click on continue with google
2.Select account and click on continue
(check for all login methods)
(For sign up, welcome text should be present)
Expected-
Welcome back screen should present once user click on continue button
Implement wrap if name is to long in size
Implement first name only
Actual-
One intermediate screen is present as shown below
First name and last name is present on screen
https://techdome-my.sharepoint.com/:v:/g/personal/shreyas_pharande_techdome_net_in/EfPTntgMo_FKnXo0un1qEWkBQQBcHol8ZZGsMKPF7KdTiQ?e=d3fxsZ
after solving
