fix tests

spatie · Jan 5, 2016 · 372af63 · 372af63
1 parent 6578b19
commit 372af63
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,10 @@ use Spatie\RobotsMiddleware\RobotsMiddleware;
 
 class MyRobotsMiddleware extends RobotsMiddleware
 {
-    protected function shouldIndex(Request $request) : bool
+    /**
+     * @return string|bool
+     */
+    protected function shouldIndex(Request $request)
     {
         return $request->segment(1) !== 'admin';
     }

diff --git a/src/RobotsMiddleware.php b/src/RobotsMiddleware.php
@@ -41,7 +41,10 @@ protected function responseWithRobots(string $contents)
         return $this->response;
     }
 
-    protected function shouldIndex(Request $request) : bool
+    /**
+     * @return string|bool
+     */
+    protected function shouldIndex(Request $request)
     {
         return true;
     }

diff --git a/tests/RobotsMiddlewareTest.php b/tests/RobotsMiddlewareTest.php
@@ -3,9 +3,6 @@
 namespace Spatie\RobotsMiddleware\Test;
 
 use Spatie\RobotsMiddleware\InvalidIndexRule;
-use Spatie\RobotsMiddleware\Test\TestMiddlewares\CustomTestMiddleware;
-use Spatie\RobotsMiddleware\Test\TestMiddlewares\InvalidTestMiddleware;
-use Spatie\RobotsMiddleware\Test\TestMiddlewares\SimpleTestMiddleware;
 
 class RobotsMiddlewareTest extends TestCase
 {

diff --git a/tests/TestMiddlewares/CustomTestMiddleware.php b/tests/TestMiddlewares/CustomTestMiddleware.php
@@ -7,7 +7,10 @@
 
 class CustomTestMiddleware extends RobotsMiddleware
 {
-    protected function shouldIndex(Request $request) : string
+    /**
+     * @return string|bool
+     */
+    protected function shouldIndex(Request $request)
     {
         if ($request->segment(1) === 'custom-tag') {
             return 'nofollow';

diff --git a/tests/TestMiddlewares/InvalidTestMiddleware.php b/tests/TestMiddlewares/InvalidTestMiddleware.php
@@ -7,6 +7,9 @@
 
 class InvalidTestMiddleware extends RobotsMiddleware
 {
+    /**
+     * @return string|bool
+     */
     protected function shouldIndex(Request $request) : array
     {
         return [];

diff --git a/tests/TestMiddlewares/SimpleTestMiddleware.php b/tests/TestMiddlewares/SimpleTestMiddleware.php
@@ -7,7 +7,10 @@
 
 class SimpleTestMiddleware extends RobotsMiddleware
 {
-    protected function shouldIndex(Request $request) : bool
+    /**
+     * @return string|bool
+     */
+    protected function shouldIndex(Request $request)
     {
         return $request->segment(1) !== 'go-away';
     }