Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make $response param explicitly nullable #564

Merged

Conversation

JonPurvis
Copy link
Contributor

Hey 👋

Whilst upgrading my application to PHP8.4, I was getting these deprecation warnings when running my test suite:

{closure:Spatie\Sitemap\SitemapGenerator::__construct():48}(): Implicitly marking parameter $response as nullable is deprecated, the explicit nullable type must be used instead

and

{closure:Spatie\Sitemap\SitemapGenerator::__construct():177}(): Implicitly marking parameter $response as nullable is deprecated, the explicit nullable type must be used instead

This PR ensures that the $reponse param is explicitly nullable and therefore no longer shows the deprecation warning.

Thanks!

@JonPurvis JonPurvis changed the title make response param explicitly nullable Make $response param explicitly nullable Jan 29, 2025
@freekmurze freekmurze merged commit 5606b9e into spatie:main Jan 31, 2025
1 check passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants