Rename externalId to externalSpdxId #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary O'Neall <[email protected]>
Closed
zvr
approved these changes
Oct 18, 2023
|
As I missed the call, I'd like to revisit this decision and discuss my proposal in #492. |
|
As there have been no updates from Gary & Jeff since Jeff's last comment, and we're not going to be getting Gary for a couple of weeks, am going ahead and merging this, as it does provide some needed clarity. |
|
@jeff-schutt - if you still feel strongly here, open a PR with the proposed change ontop of this one, and we can discuss when Gary returns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the decision in the tech call on 17 October 2023 to reduce confusion between the
externalIdandexternalIdentifierproperties.This pull request replaces #492