-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Diagram] Remove all named individuals #884
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@sbarnum Since this is about diagram, if you have few mins please take a look at the SpdxOrganization individual added. It is in the "Individuals" box in two diagrams:
Thank you for your help. |
I see two problems, none of which are directly caused by the diagram changes but rather by the changes to SPDXOrganization that led to the diagram changes.
These issues should be addressed then updated in the diagrams. BTW, there is also a remaining typo in buildType.md. There is an occurence of "builtType" rather than "buildType" |
@sbarnum see different but related discussion at #880 (comment) @zvr - thoughts? I'm OK with either URI |
fyi, these are named individuals we currently have, together with their IRIs:
(#883 is proposed to fix inconsistencies in (2) and (3)) |
Thinking more about it, I am not even sure the Individuals should appear on the diagram... I mean, we will also publish hundreds more Individuals -- the licenses and exceptions of the License List. Why show some and not all? |
In the 3.0.1 shacl TTL file, it looks like we have the standard URI |
based on the tech call on 24 Sept 2024: We'll remove the individuals from the diagram - SpdxOrganization, NoneElement, NoAssertionElement, NoneLicense, NoAssertionLicense. Resolves the inconsistencies' and allows us to move the decision on the URI's to 3.1. |
@bact will update the diagram based on the above decision |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
All named individuals are now removed from the diagrams in this PR and also in spdx/spdx-spec#1120 |
Thanks @bact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add /Core/Individuals/SpdxOrganization #880 added SpdxOrganization as a named individual to the modelSee also the change log at [CHANGELOG] Add changes in buildType and SpdxOrganization #881Per Tech Call 24 Sep 2024 - Remove all named individuals to "fix" IRI inconsistencies between the model and the diagram.
Removing: