Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese translation for models - Part IV #951

Open
wants to merge 4 commits into
base: support/3.0
Choose a base branch
from
Open

Add Chinese translation for models - Part IV #951

wants to merge 4 commits into from

Conversation

ZhengZhenyu
Copy link

Add Chinese translation for Extension, Licensing, Lite and Security models

@ZhengZhenyu
Add Chinese translation for models - Part IV
d310af5 
Add Chinese translation for Extension, Licensing, Lite and Security models

Signed-off-by: Zhenyu Zheng <[email protected]>
@bact bact added the Translation:zh-Hans Translation for Simplified Chinese label Jan 3, 2025
bact
bact requested changes Jan 4, 2025
View reviewed changes
model/Extension/Classes/Extension.md Outdated Show resolved Hide resolved
model/Extension/Classes/CdxPropertiesExtension.md Outdated Show resolved Hide resolved
model/Extension/Classes/CdxPropertiesExtension.md Outdated Show resolved Hide resolved
model/Extension/Classes/CdxPropertyEntry.md Outdated Show resolved Hide resolved
model/Extension/Classes/CdxPropertyEntry.md Outdated Show resolved Hide resolved
model/Extension/Properties/cdxPropName.md Outdated Show resolved Hide resolved
model/Extension/Properties/cdxPropValue.md Outdated Show resolved Hide resolved
model/Extension/Properties/cdxPropValue.md Outdated Show resolved Hide resolved
model/Extension/Properties/cdxProperty.md Outdated Show resolved Hide resolved
model/Extension/Properties/cdxProperty.md Outdated Show resolved Hide resolved
@ZhengZhenyu @bact
Apply suggestions from code review
cafbd57 
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Zhenyu Zheng <[email protected]>
@ZhengZhenyu ZhengZhenyu requested a review from bact January 5, 2025 02:14
bact
bact approved these changes Jan 5, 2025
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few list formatting issues. I will quickly commit those and approve this PR. Thank you for the translation.

model/Licensing/Licensing.md Outdated Show resolved Hide resolved
model/Licensing/Licensing.md Outdated Show resolved Hide resolved
bact added 2 commits January 5, 2025 04:01
@bact
One one line before and after the list
999f9fc 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
One one line before and after the list
7653fb5 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@gomico
Copy link

gomico commented Jan 21, 2025

The translation maintains the essence of the source material while adapting naturally to Chinese. No issues spotted.

@LiuPeng-running
Copy link

LGTM. The translation is excellent. It is clear that the technical understanding is correct and the language is used appropriately. A rare and outstanding translation!

@helen-ls
Copy link

The zh-Hans version LGTM. The content is well-organized and flows naturally, adhering to Chinese grammar and language conventions. It reads smoothly, and the structure is clear and easy to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact approved these changes

Assignees
No one assigned
Labels
Translation:zh-Hans Translation for Simplified Chinese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZhengZhenyu @gomico @LiuPeng-running @helen-ls @bact