Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove unnecessary field 'name' in snippets #1020

Open
wants to merge 1 commit into
base: support/2.3.1
Choose a base branch
from

Conversation

ammend
Copy link

@ammend ammend commented Aug 5, 2024

remove unnecessary field 'name' in snippets according to official spdx website. By the link below, 'name' is not required in the specification link however it is required in json schema.

@bact
Copy link
Collaborator

bact commented Aug 5, 2024

The PR failed because there's no signed-off information in the commit message.

To fix it, see: https://github.com/spdx/spdx-spec/pull/1020/checks?check_run_id=28332399503

@ammend ammend changed the title remove unnecessary field 'name' in snippets bugfix: remove unnecessary field 'name' in snippets Aug 6, 2024
@kestewart kestewart requested a review from goneall August 7, 2024 14:49
@ammend
Copy link
Author

ammend commented Aug 8, 2024

link

@goneall Thanks for your review

@goneall goneall added this to the 2.3.1 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants