-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spdx3.model to SPDX v3.0.1 #829
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Match the name in v3.0.1 Signed-off-by: Arthit Suriyawongkul <[email protected]>
declaredLicense -> hasDeclaredLicense Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Ref the table at https://github.com/spdx/using/blob/main/docs/diffs-from-previous-editions.md#translating-from-23-to-30-8 Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Generating from https://spdx.org/rdf/3.0.1/spdx-model.ttl, following steps in src/spdx_tools/spdx3/writer/json_ld/process.md Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
We might abandon this PR if we can generate the Python code from the model ontology file (I have learned from Gary that there's a work under going for that). I think that's probably a better approach in terms of maintenance (and correctness to the model). |
I agree with you
…On Mon, 4 Nov 2024 at 15:21, Arthit Suriyawongkul ***@***.***> wrote:
We might abandon this PR if we can generate the Python code from the model
ontology file. I think that's probably a better approach in terms of
maintenance.
—
Reply to this email directly, view it on GitHub
<#829 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASN5JCPORMIRTAOD25IS3FDZ65YFFAVCNFSM6AAAAABPTY72NWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJUG4YDCOJSGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Could you share any news when we might expect spdx / tools-python to support deserializing / validating v3.0.1 spdx documents? Is there some discussion further where one could subscribe to get any kind of updates on the state? Seems like this PR has been hanging for a while. |
@alcroito - we've been having some discussions on this topic on our weekly SPDX Implementers meeting. We now have the generated model files that implement SPDX 3.0.1 available in a separate repo: https://github.com/spdx/spdx-python-model The current thinking is we would refactor this tools-python code to use the generated model files, but that is quite a bit of work. One possibility is to review and merge these changes now and make the design changes later. |
Update spdx_tools.spdx3.model to the latest in SPDX v3.0.1:
spdx_tools.spdx3.model
tospdx_tools.spdx3.model.core
spdx_tools.spdx3.writer.console
tospdx_tools.spdx3.writer.console.core
ADLER32
algorithm is now availableHAS_OPTIONAL_COMPONENT
PresenceType
,SupportType
,FileKindType
RelationshipType
conversion rules in bump_from_spdx2/relationship.py: using the table from Differences between V3.0 and V2.3: Relationship as a referencePURL
->PACKAGE_URL
concludedLicense
->hasConcludedLicense
declaredLicense
->hasDeclaredLicense
sensitivePersonalInformation
->useSensitivePersonalInformation
parameters
->parameter
ExternalReference
->ExternalRef
ExternalReferenceType
->ExternalRefType
imports
->import_
(cannot use "import", as it is Python's reserved)Dataset
->DatasetPackage
sensitivePersonalInformation
->hasSensitivePersonalInformation
homepage
->homePage
(home_page
)SBOMType
->SbomType
Notes: