Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/webidl): add data-dfn-for to IDL sections #2893

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented May 21, 2020

src/core/webidl.js Outdated Show resolved Hide resolved
return;
} else {
closestSection.dataset.dfnFor = "";
const options = dfnFors.map(dfnFor => `"${dfnFor}"`).join(", ");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should not suggest these options? User might want to add something else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, don't suggest these yet... remember that this currently works today:

<section data-dfn-for="Whatever">
   
    <section>
    <pre class="idl">
        interface Whatever{};
        interface SomethingElse{};
    <pre>
    </section>
</section>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, the above is probably bad practice and doesn't matter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants