Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for speckle_type_translations #304

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gjedlicska
Copy link
Collaborator

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 97.14% and project coverage change: -0.04% ⚠️

Comparison is base (fbbd6c0) 90.31% compared to head (5013075) 90.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   90.31%   90.28%   -0.04%     
==========================================
  Files          89       93       +4     
  Lines        5286     5392     +106     
==========================================
+ Hits         4774     4868      +94     
- Misses        512      524      +12     
Files Changed Coverage Δ
src/specklepy/objects/GIS/layers.py 75.00% <80.00%> (ø)
src/specklepy/objects/GIS/CRS.py 100.00% <100.00%> (ø)
src/specklepy/objects/GIS/__init__.py 100.00% <100.00%> (ø)
src/specklepy/objects/GIS/geometry.py 100.00% <100.00%> (ø)
src/specklepy/objects/__init__.py 100.00% <100.00%> (ø)
src/specklepy/objects/base.py 83.82% <100.00%> (+0.24%) ⬆️
tests/unit/test_base.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant