-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE2 API Updates #348
Open
JR-Morgan
wants to merge
27
commits into
main
Choose a base branch
from
jedd/cxpla-95-add-fe2-queries-and-mutations-to-specklepy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FE2 API Updates #348
JR-Morgan
wants to merge
27
commits into
main
from
jedd/cxpla-95-add-fe2-queries-and-mutations-to-specklepy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-queries-and-mutations-to-specklepy
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 87.65% 89.63% +1.97%
==========================================
Files 95 128 +33
Lines 5670 6809 +1139
==========================================
+ Hits 4970 6103 +1133
- Misses 700 706 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added New Resources:
comment_resource.py- WON'T DO - I need blob support in order to integration test. Not super criticalAll of the above are implemented the same as in C# (I've tweaked the C# side also in specklesystems/speckle-sharp-sdk#144 )
Notable improvements over previous aproach:
Optional
) aligned with the GraphQL schemaChanges to existing resources:
active_user::Resource
&other_user::Resource
renamed toactive_user_resource::ActiveUserResource
andother_user_resource::OtherUserResource
I should be non-breaking, except in a few places I've changed the type hinting to correctly respect the Optionality of things,
and the
active_user
andother_user
resources will now raise rather than return exceptionsTests
Added pytest equivalents for the C# integration tests for the same queries and mutations
Had to add pytest-asyncio as a dev dependency
Things to check with Gergo:
Cursors...- A:str
,datetime
orUnion[str, datetime]
str
Happy with the integration tests? they are the same as in C#A: more than happyShould I remove the unused stuff (file import, model tree, etc...)Done anywayProject invites in with Project and Active user? or in separate place like in .NET SDK?align with sharpnew_models.py
or move them all tomodels.py
, I've had to suppress ruff is complaining about * imports