Extended publish debugging #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusting the internals for performing session requests inside the Rest helper class. This is to help prepare the implementation for future work which can help debugging using prepared requests, as well as preparing for adjustments for APIv2, which deviates from the "bind path" used in this implementation. Signed-off-by: James Knight <[email protected]>
Introduce a configuration check where a value will attempt to map to a specific enumeration type. This is to support future configuration capabilities which will try to map string values to enums. Signed-off-by: James Knight <[email protected]>
Updating the `confluence_publish_debug` option to now accept string values, used to make to specific debugging enumeration flags in the implementation. This is to prepare for additional debugging modes that can be enabled when publishing. Signed-off-by: James Knight <[email protected]>
The unit test used to debug processing a boolean type used the `confluence_publish_debug` option for checks. However, this configuration type is no longer a boolean, so updating the unit test to use a new type (`confluence_publish_force`). Signed-off-by: James Knight <[email protected]>
Updates the `confluence_publish_debug` option to now accept a new value `headers`, which can be used to dump requests and responses, with their header data, made to a configured Confluence instance. Signed-off-by: James Knight <[email protected]>
Updates the `confluence_publish_debug` option to now accept a new value `deprecated`, which can be used by developers to help warn when using API calls that Atlassian has marked as deprecated. Signed-off-by: James Knight <[email protected]>
With updates to `confluence_publish_debug` to accept string values for various debugging modes, updating the documentation to reflect the new values which can be set. Signed-off-by: James Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rest: refactor request processing
Adjusting the internals for performing session requests inside the Rest helper class. This is to help prepare the implementation for future work which can help debugging using prepared requests, as well as preparing for adjustments for APIv2, which deviates from the "bind path" used in this implementation.
config: provide enum-type check
Introduce a configuration check where a value will attempt to map to a specific enumeration type. This is to support future configuration capabilities which will try to map string values to enums.
switch publish-debug config to be an enum-flag type
Updating the
confluence_publish_debugoption to now accept string values, used to make to specific debugging enumeration flags in the implementation. This is to prepare for additional debugging modes that can be enabled when publishing.tests: adjust env bool test to use new option
The unit test used to debug processing a boolean type used the
confluence_publish_debugoption for checks. However, this configuration type is no longer a boolean, so updating the unit test to use a new type (confluence_publish_force).support request/response header dumps when publishing
Updates the
confluence_publish_debugoption to now accept a new valueheaders, which can be used to dump requests and responses, with their header data, made to a configured Confluence instance.support deprecated api warnings when publishing
Updates the
confluence_publish_debugoption to now accept a new valuedeprecated, which can be used by developers to help warn when using API calls that Atlassian has marked as deprecated.doc: update new confluence_publish_debug str-options
With updates to
confluence_publish_debugto accept string values for various debugging modes, updating the documentation to reflect the new values which can be set.