pass max width to latex adjustbox #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When creating large diagrams using plantuml, they can quickly get too wide for a pdf page. For images in the png, pdf and svg format, this problem is handled by the sphinx-provided "sphinxincludegraphics" latex command, which resizes the included graphic if needed. As tikz images are embedded using the "\input" command, this resize logic is not applicable for them. Solution: I would suggest to use the "max-width" option (which is already somehow implemented but not documented) to allow the user to specify a maximum width. The "adjustbox" macro, which is already being used for giving an absolute size for an image, also supports this type of maximum size. This way, the image is not resized if it fits, but only if it would exceed the given size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90