Enhancing and standardizing Clickhouse documentation #604
+57
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sgrebnov
previously approved these changes
Nov 12, 2024
| | `clickhouse_user` | The username to connect with. | | ||
| | `clickhouse_pass` | The password to connect with. | | ||
| | `clickhouse_secure` | Optional. Specifies the SSL/TLS behavior for the connection, supported values:<br /> <ul><li>`true`: (default) This mode requires an SSL connection. If a secure connection cannot be established, server will not connect.</li><li>`false`: This mode will not attempt to use an SSL connection, even if the server supports it.</li></ul> | | ||
| | `connection_timeout` | Optional. Specifies the connection timeout in milliseconds. | |
There was a problem hiding this comment.
This should support specifying the timeout in the same format as our other timeout parameters, in a human readable format like 10s or 1m.
There was a problem hiding this comment.
I don't think we need to do this now, but we should at least create an issue to track it, since its inconsistent with our other connectors.
Co-authored-by: Phillip LeBlanc <[email protected]>
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Standardizing the connector documentation as outlined in #580
🔨 Related Issues
🤔 Concerns