Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base implementation + Flight API #1

Merged
merged 26 commits into from
Jun 19, 2024
Merged

Conversation

gloomweaver
Copy link
Contributor

@gloomweaver gloomweaver commented Jun 11, 2024

Main implementation for c# sdk
Retrying will be included in the separate PR.
Currently not working against local runtime.
Addressed in apache/arrow#42132

@gloomweaver gloomweaver self-assigned this Jun 11, 2024
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from d88ad47 to 0eae03b Compare June 11, 2024 07:25
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from 7f4cd89 to adf3e5a Compare June 11, 2024 09:16
@gloomweaver gloomweaver changed the title Base implementation Base implementation + Flight API Jun 11, 2024
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from 18353aa to 2293866 Compare June 13, 2024 00:17
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from 2293866 to 5f9813f Compare June 13, 2024 00:18
Fix Query method on SpiceFlightClient.cs
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from 2de564d to 9069f30 Compare June 13, 2024 01:05
@gloomweaver gloomweaver marked this pull request as ready for review June 13, 2024 01:07
Copy link
Contributor

@sgrebnov sgrebnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add min Readme.md - build + class usage.

Spice/.idea/.idea.Spice/.idea/indexLayout.xml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Show resolved Hide resolved
Spice/Spice.csproj Show resolved Hide resolved
Spice/Spice.csproj Show resolved Hide resolved
Spice/src/Config/SpiceDefaultConfigCloud.cs Show resolved Hide resolved
Spice/src/Flight/SpiceFlightClient.cs Show resolved Hide resolved
Spice/src/SpiceClientBuilder.cs Show resolved Hide resolved
SpiceTest/FlightQueryTest.cs Outdated Show resolved Hide resolved
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from 050d819 to de10e86 Compare June 14, 2024 11:35
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from fa03560 to d666fb1 Compare June 14, 2024 12:27
@gloomweaver gloomweaver force-pushed the kkhramkov/base-implementation branch from d8fc8db to 92d05c4 Compare June 14, 2024 14:30
Spice/src/Flight/SpiceFlightClient.cs Show resolved Hide resolved
Spice/src/Flight/SpiceFlightClient.cs Outdated Show resolved Hide resolved
Spice/src/Flight/SpiceFlightClient.cs Outdated Show resolved Hide resolved
Spice/src/Config/SpiceDefaultConfigCloud.cs Show resolved Hide resolved
Copy link
Contributor

@digadeesh digadeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally hit approve so putting the request changes note here. Please address the comments and then we can re-review.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
digadeesh
digadeesh previously approved these changes Jun 17, 2024
@digadeesh digadeesh self-requested a review June 17, 2024 05:26
@digadeesh digadeesh dismissed their stale review June 18, 2024 06:02

I put in comments and accidentally approved instead of selecting comment.

digadeesh
digadeesh previously approved these changes Jun 18, 2024
Spice/src/Errors/SpiceException.cs Outdated Show resolved Hide resolved
@gloomweaver gloomweaver merged commit 5a379fb into trunk Jun 19, 2024
1 check passed
@gloomweaver gloomweaver deleted the kkhramkov/base-implementation branch June 19, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants