feat: Use winver for Windows release version

spiceai · Sep 19, 2024 · 6f04031 · 6f04031
1 parent 2eae58d
commit 6f04031
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Cargo.toml b/Cargo.toml
@@ -28,5 +28,8 @@ arrow = "51.0.0"
 futures = "0.3.30"
 base64 = "0.22.0"
 
+[target.'cfg(windows)'.dependencies]
+winver = "1.0.0"
+
 [dev-dependencies]
 regex = "1.10.6"
diff --git a/src/config.rs b/src/config.rs
@@ -16,7 +16,9 @@ fn get_os_release() -> Result<String, Box<dyn std::error::Error>> {
 
 #[cfg(target_family = "windows")]
 fn get_os_release() -> Result<String, Box<dyn std::error::Error>> {
-    todo!("get_os_release not implemented for Windows")
+    use winver::WindowsVersion;
+    let version = WindowsVersion::get()?;
+    Ok(version.to_string())
 }
 
 pub(crate) fn get_user_agent() -> String {