Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (Snippets) Remove the artists and credits sections from the sidebar #899

Conversation

FoxyLoon
Copy link
Contributor

Addition of a new snippet that allows you to show the album cover and the next song centered at the same time. There is a similar snippet but it only shows the cover image. I prefer to have the next song also shown, so I've added this option as well.

@FoxyLoon FoxyLoon requested a review from a team as a code owner February 15, 2025 01:39
@FoxyLoon FoxyLoon requested review from rxri and removed request for a team February 15, 2025 01:39
@FoxyLoon FoxyLoon changed the title Add snippet remove the artists and credits sections from the sidebar feat(snippets): Remove the artists and credits sections from the sidebar Feb 15, 2025
@FoxyLoon FoxyLoon changed the title feat(snippets): Remove the artists and credits sections from the sidebar feat(snippets) Remove the artists and credits sections from the sidebar Feb 15, 2025
@FoxyLoon FoxyLoon changed the title feat(snippets) Remove the artists and credits sections from the sidebar feat: (Snippets) Remove the artists and credits sections from the sidebar Feb 15, 2025
@rxri rxri merged commit 067ed1b into spicetify:main Feb 18, 2025
4 checks passed
@rxri
Copy link
Member

rxri commented Feb 18, 2025

holy fuck how tf it passed pr lint...

@rxri
Copy link
Member

rxri commented Feb 18, 2025

Read https://www.conventionalcommits.org/en/v1.0.0/ how this template works for commits for next time

@FoxyLoon
Copy link
Contributor Author

holy fuck how tf it passed pr lint...

It passed because of the title I gave this “pull request”.

If you notice, I even edited the title a few times because “it wasn't passing that ‘lint’”, so I thought it was a mistake. I experimented a bit and ended up reading what was written in a documentation that github suggested near the error to theoretically make it correct.

I was initially going to put it as “feat(snippets): (...)” because of the other examples I've seen, but since I was getting an error with that “lint” and the documentation said it was just “feat:”, I ended up changing the terms. I honestly didn't know it was supposed to be any other way.

I'm still relatively new to working with github, so sorry about that. I'm still learning a few things. This was my first attempt ahahahaha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants