Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getFinalOwner method to handle not found error #4713

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Mar 3, 2025

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes ##4714

Special notes for your reviewer:

环境上存在 Pod Owner 不在的情况,对于 Pod Owner 不在的情况,不打印 warn 级别日志,改为 debug 级别日志。

@lou-lan lou-lan changed the title Failed to get final owner for PyTorchJob in PodOwnerCache when PyTorchJob delete Update getFinalOwner method to handle not found error Mar 3, 2025
@lou-lan lou-lan force-pushed the update/get-final-owner branch from 7d56099 to ed3073a Compare March 3, 2025 09:52
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (245f6c8) to head (3f41213).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4713      +/-   ##
==========================================
- Coverage   75.38%   75.35%   -0.03%     
==========================================
  Files          56       56              
  Lines        6816     6820       +4     
==========================================
+ Hits         5138     5139       +1     
- Misses       1466     1469       +3     
  Partials      212      212              
Flag Coverage Δ
unittests 75.35% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/podownercache/pod_owner_cache.go 83.78% <100.00%> (+0.60%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lou-lan lou-lan added the pr/not-ready not ready for merging label Mar 3, 2025
@lou-lan lou-lan force-pushed the update/get-final-owner branch from ed3073a to 3f41213 Compare March 3, 2025 10:12
@lou-lan lou-lan added release/bug and removed pr/not-ready not ready for merging labels Mar 3, 2025
@weizhoublue weizhoublue added release/none no release note and removed release/bug labels Mar 7, 2025
@weizhoublue
Copy link
Collaborator

possibly, it should label with cherry-pick

@lou-lan lou-lan added the cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. label Mar 7, 2025
@lou-lan lou-lan merged commit c1eeeff into main Mar 7, 2025
59 checks passed
@lou-lan lou-lan deleted the update/get-final-owner branch March 7, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick-release-v1.0 Cherry-pick the PR to branch release-v1.0. release/none no release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants