Angular Signal Store #195

spierala · 2023-07-03T19:07:58Z

See the RFC for more information about the MiniRx Signal Store.

A pre-release version (build from this PR code) has been published on NPM: https://www.npmjs.com/package/@mini-rx/signal-store

This PR also contains a new library: @mini-rx/common: common contains shared code which is used by Signal Store and will be used by the original mini-rx-store in the future. @mini-rx/common will be installed as a dependency of Signal Store.

The Signal Store API is very similar to the original mini-rx-store, these are the main differences:

effect functions are renamed to rxEffect (to avoid confusion with the Angular Signal effect function)
rxEffect in FeatureStore/ComponentStore supports Signal as trigger (next to Observable and raw value)
no setInitialState anymore in FeatureStore/ComponentStore for lazy state initialisation. An initialState is required, which is more inline with native Angular Signals.
select methods return Signal instead of Observable
connect method was added to FeatureStore/ComponentStore to easily connect the stores with external Signals/Observables
setState does not accept an Observable anymore (use connect instead)
memoized selectors from createSelector, createFeatureStateSelector use Angular computed internally for memoization. The selector creation functions return a function which takes a Signal and returns a Signal.

You can find more info about the changed APIs in this blogpost: https://dev.to/this-is-angular/minirx-signal-store-for-angular-api-preview-4e16

…e into signal-store-tests

Signal store tests

…improvements

reducer manager needs a default reducer to prevent "null pointers" when initialising the store without registered reducers

libs/common/src/lib/combine-reducers.spec.ts

carlos-ds · 2023-12-15T13:56:03Z

Getting an upstream dependency conflict error when running npm install. Perhaps you'll want to fix this?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @angular-devkit/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"29.4.3" from the root project
npm ERR!   peer jest@"^29.0.0" from [email protected]
npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev jest-preset-angular@"13.1.1" from the root project
npm ERR!   1 more (ts-jest)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional jest@"^29.5.0" from @angular-devkit/[email protected]
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev @angular-devkit/build-angular@"16.1.1" from the root project
npm ERR!   peer @angular-devkit/build-angular@">= 14.0.0 < 17.0.0" from @nx/[email protected]
npm ERR!   node_modules/@nx/angular
npm ERR!     @nx/angular@"16.4.0" from the root project
npm ERR!     1 more (@nrwl/angular)
npm ERR!   1 more (jest-preset-angular)
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/jest
npm ERR!   peerOptional jest@"^29.5.0" from @angular-devkit/[email protected]
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"16.1.1" from the root project
npm ERR!     peer @angular-devkit/build-angular@">= 14.0.0 < 17.0.0" from @nx/[email protected]
npm ERR!     node_modules/@nx/angular
npm ERR!       @nx/angular@"16.4.0" from the root project
npm ERR!       1 more (@nrwl/angular)
npm ERR!     1 more (jest-preset-angular)
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

spierala · 2023-12-22T16:28:55Z

Getting an upstream dependency conflict error when running npm install. Perhaps you'll want to fix this?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @angular-devkit/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/jest
npm ERR!   dev jest@"29.4.3" from the root project
npm ERR!   peer jest@"^29.0.0" from [email protected]
npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev jest-preset-angular@"13.1.1" from the root project
npm ERR!   1 more (ts-jest)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional jest@"^29.5.0" from @angular-devkit/[email protected]
npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev @angular-devkit/build-angular@"16.1.1" from the root project
npm ERR!   peer @angular-devkit/build-angular@">= 14.0.0 < 17.0.0" from @nx/[email protected]
npm ERR!   node_modules/@nx/angular
npm ERR!     @nx/angular@"16.4.0" from the root project
npm ERR!     1 more (@nrwl/angular)
npm ERR!   1 more (jest-preset-angular)
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/jest
npm ERR!   peerOptional jest@"^29.5.0" from @angular-devkit/[email protected]
npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev @angular-devkit/build-angular@"16.1.1" from the root project
npm ERR!     peer @angular-devkit/build-angular@">= 14.0.0 < 17.0.0" from @nx/[email protected]
npm ERR!     node_modules/@nx/angular
npm ERR!       @nx/angular@"16.4.0" from the root project
npm ERR!       1 more (@nrwl/angular)
npm ERR!     1 more (jest-preset-angular)
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@carlos-ds
The repo uses yarn. Thanks for your PR updating the contribution guidelines for yarn!

carlos-ds · 2024-01-05T19:21:40Z

libs/common/src/lib/combine-reducers.ts

+
+        for (let i = 0; i < reducerKeyLength; i++) {
+            const key = reducerKeys[i];
+            const reducer: any = reducers[key];


Is there a reason why this is explicitly typed as any ? That seems unnecessary and incorrect, since it is inferred as Reducer<any>

Reducer is indeed better than any.

carlos-ds · 2024-01-05T19:30:32Z

libs/common/src/lib/deep-freeze.spec.ts

@@ -0,0 +1,87 @@
+import { deepFreeze } from './deep-freeze';
+
+// Created a cool set of unit tests with ChatGPT: https://chat.openai.com/share/f2a078c9-e996-4d4e-8c4c-725ca2e9cafd


Perhaps this comment can be removed?

I prefer to be transparent about copy-pasted stuff from ChatGPT or stack-overflow.

The comment text I adjusted a little bit now.

carlos-ds · 2024-01-05T19:33:47Z

libs/common/src/lib/deep-freeze.spec.ts

+            return 42;
+        };
+        expect(() => deepFreeze(fn)).not.toThrow();
+        // Test that the function object is frozen


This comment seems obsolete? Same for the other comments that state 'Test that ... is/are frozen'

I removed two not useful comments. The others have at least a little bit extra information which could be useful.

carlos-ds · 2024-01-05T19:37:26Z

libs/common/src/lib/default-effects-error-handler.ts

+// Prevent effect to unsubscribe from the actions stream
+export function defaultEffectsErrorHandler<T>(
+    observable$: Observable<T>,
+    retryAttemptLeft = 10


I think retryAttemptsLeft would be better in a grammatical sense

yes, retryAttemptsLeft it is :)

…l-store # Conflicts: # package.json

mini-rx and others added 30 commits May 6, 2023 21:31

feat(signal-store): create publishable library

fb319fb

feat(signal-store): signal store

6b6c068

feat(signal-store-angular-demo): signal-store-angular-demo

d1c8091

feat(signal-store): signal store

a9f8f0f

feat(signal-store): signal store: Signal Selector specs

68271b2

feat(signal-store): signal store: specs

b275e15

feat(signal-store): signal store: specs

80cda3e

feat(signal-store): signal store: specs

637c18b

feat(signal-store): signal store: specs

9020ede

feat(signal-store): signal store: specs

302b59f

feat(signal-store): signal store: specs

7255cc4

feat(signal-store): signal store: specs

821a2d0

npx nx migrate --run-migrations

0b5cb7a

feat(signal-store): signal store: specs

1d7a142

feat(signal-store): signal store: specs

a8fb620

feat(signal-store): signal store: specs

fd83ca2

Add npm task

f4c4cb7

Fix signal store demo

fe6d943

feat(signal-store): fix demo

6770902

feat(signal-store): fix demo

5cccc1e

Merge branch 'signal-store-tests' of github.com:spierala/mini-rx-stor…

3eda308

…e into signal-store-tests

feat(signal-store): signal store: specs

54cfc99

Merge pull request #191 from spierala/signal-store-tests

61dd5c7

Signal store tests

feat(signal-store): signal store: specs

3655bd5

feat(signal-store): signal store: specs

825b996

feat(signal-store): signal store: specs

fe1f692

feat(signal-store): signal store: specs

72a06f7

feat(signal-store): signal store: specs fix demo src link

7665723

feat(signal-store): signal store: providers

05caa4d

feat(signal-store): signal store: ng-modules tests

fac802e

mini-rx added 7 commits November 28, 2023 22:18

feat(signal-store, common): more lightweight injection tokens

f6fcff6

feat(signal-store, common): better component store config error

139ab38

feat(signal-store, common): reduce bundle size

0a87042

feat(common): isFunction

a41044f

feat(common): easier calculate extensions and more minor bundle size …

7b3f9e5

…improvements

feat(signal-store): rename dispatcher => updateState

db082fa

fix(common): add reducer manager default reducer

369c177

reducer manager needs a default reducer to prevent "null pointers" when initialising the store without registered reducers

carlos-ds reviewed Dec 15, 2023

View reviewed changes

libs/common/src/lib/combine-reducers.spec.ts Outdated Show resolved Hide resolved

portofantwerpbruges and others added 4 commits December 15, 2023 18:04

feat(common): improve test describe

a8dd587

chore(all): relax jest dependencies

6996eac

chore(all): use yarn

d47b646

chore(all): use yarn, node 18

511d9dd

Merge remote-tracking branch 'origin/master' into signal-store

cbbf12d

carlos-ds reviewed Jan 5, 2024

View reviewed changes

mini-rx added 8 commits January 6, 2024 15:46

feat(common): better typing of reducer

42f1a14

feat(common): better comment

2c69c39

feat(common): remove not useful comments

c306f7b

feat(common): retryAttemptsLeft

c369b4f

Merge branch 'master' of github.com:spierala/mini-rx-store into signa…

0cefb28

…l-store # Conflicts: # package.json

refactor(common, signal-store): use UpdateStateCallback

52b53e4

refactor(signal-store): remove obsolete wrapper fn for isSignal

cd90166

docs(common, signal-store): add comments

6008062

carlos-ds approved these changes Jan 22, 2024

View reviewed changes

spierala merged commit 1dd2e02 into master Jan 27, 2024
1 check passed

spierala deleted the signal-store branch January 27, 2024 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular Signal Store #195

Angular Signal Store #195

spierala commented Jul 3, 2023 •

edited

Loading

carlos-ds commented Dec 15, 2023

spierala commented Dec 22, 2023

carlos-ds Jan 5, 2024 •

edited

Loading

spierala Jan 6, 2024

carlos-ds Jan 5, 2024

spierala Jan 6, 2024

carlos-ds Jan 5, 2024 •

edited

Loading

spierala Jan 6, 2024

carlos-ds Jan 5, 2024

spierala Jan 6, 2024

		@@ -0,0 +1,87 @@
		import { deepFreeze } from './deep-freeze';

		// Created a cool set of unit tests with ChatGPT: https://chat.openai.com/share/f2a078c9-e996-4d4e-8c4c-725ca2e9cafd

Angular Signal Store #195

Angular Signal Store #195

Conversation

spierala commented Jul 3, 2023 • edited Loading

carlos-ds commented Dec 15, 2023

spierala commented Dec 22, 2023

carlos-ds Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

spierala Jan 6, 2024

Choose a reason for hiding this comment

carlos-ds Jan 5, 2024

Choose a reason for hiding this comment

spierala Jan 6, 2024

Choose a reason for hiding this comment

carlos-ds Jan 5, 2024 • edited Loading

Choose a reason for hiding this comment

spierala Jan 6, 2024

Choose a reason for hiding this comment

carlos-ds Jan 5, 2024

Choose a reason for hiding this comment

spierala Jan 6, 2024

Choose a reason for hiding this comment

spierala commented Jul 3, 2023 •

edited

Loading

carlos-ds Jan 5, 2024 •

edited

Loading

carlos-ds Jan 5, 2024 •

edited

Loading