Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested documentation for helm-charts-hardened chart #293

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

Nested documentation for helm-charts-hardened chart #293

wants to merge 31 commits into from

Conversation

kfox1111
Copy link
Contributor

No description provided.

@kfox1111
Add support for building/testing with podman
8572238 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add initial documentation for the help-charts-hardened chart
81f0b1c 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add ingress documentation
1fdd29e 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add basic federation docs and misc fixes
9594962 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add recommendations, some nested spire docs, and misc changes
413654f 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Remove unneeded bits
1f5e7dc 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add Namespace documentation
07be920 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add initial mirroring docs
7d5e199 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Update docs for external agents
0707c55 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Can't use controller manager with join tokens
7ccc531 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
More examples
7bef05c 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Make image better
bc79ea2 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Update diagrams
ff9beec 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Update things
145169a 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Reorder docs
34d3944 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
More updates
b87cb48 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Incorperate feedback
fc2fbd5 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Incorperate feedback
6d012cc 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Add join token details
e6ebb17 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Update
1412a7d 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Incorperate feedback
1e6a142 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Better diagram
294c52b 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Break out ready docs from nonready
74d0b0a 
Signed-off-by: Kevin Fox <[email protected]>
@kfox1111
Nested documentation for helm-charts-hardened chart
a1aa0b6 
Signed-off-by: Kevin Fox <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024 •
edited
Loading

✅ Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit 2a44401
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/662a5b1d2b22bb0008d91a60
😎 Deploy Preview https://deploy-preview-293--spiffe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kfox1111 kfox1111 marked this pull request as draft January 23, 2024 09:22
@kfox1111
Update diagram
19aa932 
Signed-off-by: Kevin Fox <[email protected]>
@quintessence quintessence mentioned this pull request Mar 12, 2024
Merged
mrsabath
mrsabath reviewed Apr 25, 2024
View reviewed changes
Copy link

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really helpful documentation. Here is my first pass on some text nits

content/docs/latest/spire-helm-charts-hardened-about/upgrading.md Outdated Show resolved Hide resolved
content/docs/latest/spire-helm-charts-hardened-about/recommendations.md Outdated Show resolved Hide resolved
content/docs/latest/spire-helm-charts-hardened-about/recommendations.md Outdated Show resolved Hide resolved
content/docs/latest/spire-helm-charts-hardened-advanced/nested-spire.md Outdated Show resolved Hide resolved
content/docs/latest/spire-helm-charts-hardened-advanced/nested-spire.md Outdated Show resolved Hide resolved
@kfox1111 @mrsabath
Apply suggestions from code review
2a44401 
Signed-off-by: Kevin Fox <[email protected]>

Co-authored-by: Mariusz Sabath <[email protected]>
@elinesterov
Copy link
Contributor

Can we merge this?

@kfox1111
Copy link
Contributor Author

kfox1111 commented May 7, 2024

Can we merge this?

Still trying to get the last bits into the helm chart git repository before we can finish this pr up.

@kfox1111 kfox1111 mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsabath mrsabath mrsabath left review comments

@sanderson042 sanderson042 Awaiting requested review from sanderson042 sanderson042 is a code owner

@mchurichi mchurichi Awaiting requested review from mchurichi mchurichi is a code owner

@ajessup ajessup Awaiting requested review from ajessup ajessup is a code owner

@Andres-GC Andres-GC Awaiting requested review from Andres-GC Andres-GC is a code owner

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@umairmkhan umairmkhan Awaiting requested review from umairmkhan umairmkhan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfox1111 @elinesterov @mrsabath