Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a few broken URLs from older PRs #299

Closed
wants to merge 4 commits into from
Closed

Fixing a few broken URLs from older PRs #299

wants to merge 4 commits into from

Conversation

quintessence
Copy link
Contributor

Description of the change
Fixing broken URLs that were fixed in other open PRs. See list.

Which issue this PR fixes

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for spiffe ready!

Name Link
🔨 Latest commit 7822208
🔍 Latest deploy log https://app.netlify.com/sites/spiffe/deploys/65eb982407e3140008fc2bdc
😎 Deploy Preview https://deploy-preview-299--spiffe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@quintessence
Copy link
Contributor Author

For this PR - can we squash the commit since it pulled in a duplicate of the same HeadBucket commit. I'll delete and re-create my fork after, something weird must've happened when I tried to sync my fork.

@sanderson042
Copy link
Contributor

In git terms, "squash the commits" means to combine multiple commits into one commit. It doesn't mean to delete a commit. I think the safest course here is to close this PR and try one more time.

Before starting the new branch for the new PR, be sure to set the working branch to main (git checkout master) and do git pull upstream master (or an equivalent using your git tool of choice). Then create your new branch and recreate these changes on that branch. Publish the new branch as a draft and make sure that pesky old commit doesn't show up. If it's good, then convert the draft PR to a real PR by clicking Ready For Review in GitHub.

@quintessence
Copy link
Contributor Author

Got it - I'm going to go ahead and try to repair my fork then - issues got worse when I used the "sync fork feature" which had unintended consequences. I'll also delete PR #300 and I'll make both these in one PR for simplicity in the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants