- added support for SELECT FOR UPDATE

- added stable 7.4 version
spiral-modules · Dec 11, 2019 · a8c25c6 · a8c25c6
1 parent 8a1e277
commit a8c25c6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Driver/SQLServer/SQLServerCompiler.php b/src/Driver/SQLServer/SQLServerCompiler.php
@@ -152,7 +152,7 @@ private function baseSelect(
             $this->optional(' ', $this->compileDistinct($bindings, $distinct)),
             $this->compileColumns($bindings, $columns),
             $tableNames,
-            $this->optional(' ', $forUpdate ? 'WITH (UPDLOCK, ROWLOCK)' : '', ' '),
+            $this->optional(' ', $forUpdate ? 'WITH (UPDLOCK,ROWLOCK)' : '', ' '),
             $this->optional(' ', $joinsStatement, ' '),
             $this->optional("\nWHERE", $this->compileWhere($bindings, $whereTokens)),
             $this->optional("\nGROUP BY", $this->compileGroupBy($bindings, $grouping), ' '),

diff --git a/tests/Database/SQLServer/SelectQueryTest.php b/tests/Database/SQLServer/SelectQueryTest.php
@@ -78,7 +78,7 @@ public function testSelectForUpdate(): void
             ->forUpdate();
 
         $this->assertSameQuery(
-            'SELECT * FROM {users} WITH(UPDLOCK) WHERE {name} = ?',
+            'SELECT * FROM {users} WITH(UPDLOCK,ROWLOCK) WHERE {name} = ?',
             $select
         );
     }