Skip to content

Commit

Permalink
fix: Remove Scan::build function (#1964)
Browse files Browse the repository at this point in the history
  • Loading branch information
robert3005 authored Jan 15, 2025
1 parent b20b2a7 commit b45d46c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions vortex-file/src/v2/file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ impl Scan {
pub fn new(projection: ExprRef, filter: Option<ExprRef>) -> Self {
Self { projection, filter }
}

pub fn build(self, dtype: DType) -> VortexResult<Arc<Scanner>> {
Ok(Arc::new(Scanner::new(dtype, self.projection, self.filter)?))
}
}

/// Async implementation of Vortex File.
Expand Down Expand Up @@ -141,7 +137,11 @@ impl<I: IoDriver> VortexFile<I> {
where
R: Iterator<Item = RowMask> + Send + 'static,
{
let scanner = scan.build(self.dtype().clone())?;
let scanner = Arc::new(Scanner::new(
self.dtype().clone(),
scan.projection,
scan.filter,
)?);

let result_dtype = scanner.result_dtype().clone();

Expand Down

0 comments on commit b45d46c

Please sign in to comment.