Skip to content

Commit

Permalink
the min/max of an array without valid values is not defined (and defi…
Browse files Browse the repository at this point in the history
…nitely not null)
  • Loading branch information
danking committed Jan 15, 2025
1 parent 7bc264c commit f0a0e99
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vortex-array/src/array/primitive/stats.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ mod test {
let min: Option<Scalar> = arr.statistics().compute(Stat::Min);
let max: Option<Scalar> = arr.statistics().compute(Stat::Max);
let null_i32 = Scalar::null(DType::Primitive(PType::I32, Nullability::Nullable));
assert_eq!(min, Some(null_i32.clone()));
assert_eq!(max, Some(null_i32));
assert_eq!(min, None);
assert_eq!(max, None);
}
}

0 comments on commit f0a0e99

Please sign in to comment.