-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python global install #64
Open
omckeon
wants to merge
13
commits into
splashkit:master
Choose a base branch
from
omckeon:fix/python
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+258
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om .bashrc/.bash_profile/.zshrc files
…ent variable in cleaner way with powershell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the global install to copy the splashkit.py file to the global python location and updates the splashkit.py file generated from splashkit-core.
Changes
SplashKit.dll
) to /mingw64/lib as this was needed for the splashkit.py library loading to be able to use the global lib folder.skm
when running python files.Note: This issue was solved with the help of @Liquidscroll.
skm help python3
command to include global commands.skm uninstall
command to remove global files and remove splashkit path from .bashrc/.bash_profile/.zshrc and remove splashkit paths from Windows User "Path" environment variable.skm-install.sh
script to add splashkit paths to Windows User "Path" environment variable using powershell. This reduces the extra "junk" paths that are added/duplicated to the User "Path" from the System "Path" with the previous format/code.How has this been tested?
.splashkit
folder after running initial bash install script command.python3 program.py
).skm uninstall
command to check files were changed/removed as expected (with success).Note: Above steps were tested on Linux (Ubuntu and Manjaro), Windows (MSYS2 and WSL) and macOS.
Global python testing results
Using the following test program code:
Linux (Ubuntu):
Linux (Manjaro):
Windows (MSYS2):
Windows (WSL):
macOS: