Fix CI tests + translator issue #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'SDL_AUDIODRIVER: disk' env parameter to all workflows - Make `delay` test optional on macOS - Add suffix for circle_triangle_intersect overload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with the CI tests and workflows so that they pass again.
Details
CI Tests were failing for the following reasons:
delayon macOS seems to be a lot less accurate than the other two (maybe just in the workflow VM?), the related utility test was failingcircle_triangle_intersecthad an overload but no unique suffix, causing the translator to failThe audio issue is fixed by adding
SDL_AUDIODRIVER: diskas an environment variable to all platforms. The audio is now written to a file (and if we wanted to test against that data we presumably could).The
delaytest is made optional on macOS - the check is ran but the test won't fail even if it doesn't pass. And a suffix is added for thecircle_triangle_intersectoverload.With this the CI tests pass again 😃