A workaround for #275 and a patch for #416 #417
Conversation
A workaround for issue #275
oops, forgot a comment
|
|
||
| class P extends BlockTag | ||
| { | ||
| parent::open($attr, $ahtml, $ihtml); |
There was a problem hiding this comment.
This change the behavior of P elements for everybody, is that a correct interpretation?
Then you probably fixed this problem by creating an problem at another place?
Another problem is that the library has to be fixed manually on every update of the library. So is there not an alternative approach that solves the issue in a manner that does not need manual fixes of the library each update?
There was a problem hiding this comment.
Correct. This will make paragraphs inline, as it should be in HTML. That makes pictures float.
I've being using it for a year, works fine on my setup, but sure it requires more different tests. The most questionable thing is that we replace a natural paragraph line break with a BR element which has different stylesheet. For example, slightly bigger top/bottom margins. So, it is a workaround, but it makes things work.
I wish there were something better than patching mpdf. Well... may be we can patch "p" at runtime from the plugin? Can PHP substitute a whole existing class?
There was a problem hiding this comment.
I do no understand why mpdf would do this, and therefore i do also not know if this change is right.
Changes for mpdf library should be proposed in the https://github.com/mpdf/mpdf repository.
|
Is using divs the only way to align the pictures? Because this solution needs changes to mpdf library, I will not merge it. Please propose the needed fixes first upstream. |
No description provided.