Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git - Add Action - add on_poll action #18

Open
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

asur1on
Copy link

@asur1on asur1on commented Sep 11, 2024

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • [ X ] Testing of all the changes has been performed (for bug fixes / features)
  • [ X ] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • [ X ] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • [ X ] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • [ X ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • [ X ] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • [ X ] Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
    Created subset functions __git_pull, __git_status, and __git_clone for use in an on_poll action. on_poll will make use of the branch and repo configured in an asset config to regularly check for new updates on the branch

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.
    add on_poll behavior

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

asur1on and others added 2 commits September 11, 2024 10:27
* Add files via upload

* Add files via upload
* Add files via upload

* Update README.md

---------

Co-authored-by: splunk-soar-connectors-admin <admin@splunksoar>
@splunk-soar-connectors-bot
Copy link
Collaborator

Thank you for your submission! We have a total of 20 PRs open right now, and we are working hard on all of them! We will take a look as soon as we can.

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

mmomin-crest and others added 2 commits October 15, 2024 19:33
Add release notes.
Bugfix: for getting an optional parameter, use get() function.
@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit ea54a30 - https://drive.google.com/file/d/1rmO2-BdMtieaPAPiWvkk0BUrO4lFExPN/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit ea54a30 - https://drive.google.com/file/d/1_jABz8xQT5h8qwTrPu2Q8zfcqX75-7oE/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Static Tests results for commit c8b799c - https://drive.google.com/file/d/1istWYoaC_ZYkyP6DTD_0Z1HrMlf-LsgZ/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@github-actions[bot] Compile Tests results for commit c8b799c - https://drive.google.com/file/d/1dbYbm5snVpj22_fF1zXC2HUQU0QOUVWx/view?usp=drivesdk

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants