Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAPP-32932 Msscom: Feature - support for different authentication methods #12

Open
wants to merge 12 commits into
base: next
Choose a base branch
from
Open

PAPP-32932 Msscom: Feature - support for different authentication methods #12

wants to merge 12 commits into from

Conversation

mposluszny-splunk
Copy link

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

@mposluszny-splunk mposluszny-splunk self-assigned this Dec 12, 2023
bb-splunk
bb-splunk requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@bb-splunk bb-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the stuff I wrote in that review https://github.com/splunk-soar-connectors/microsoftsccm/pull/11/files also aplies here

bbielinski-splunk
bbielinski-splunk requested changes Dec 12, 2023
View reviewed changes
microsoftscom_connector.py Outdated
Comment on lines 90 to 92
if self._auth_type != MSSCOM_DEFAULT_AUTH_METHOD:
transport = self._auth_type
elif self._get_fips_enabled():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as in #11

bb-splunk
bb-splunk reviewed Dec 13, 2023
View reviewed changes
microsoftscom_connector.py
@@ -42,6 +42,7 @@ def __init__(self):
# Configuration variables
self._server_url = None
self._username = None
self._auth_type = MSSCOM_DEFAULT_AUTH_METHOD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the other fields from config you've added be here as well?

@mposluszny-splunk mposluszny-splunk changed the title SOARHELP-2713 Msscom: Feature - support for different authentication methods PAPP-32932 Msscom: Feature - support for different authentication methods Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb-splunk bb-splunk bb-splunk requested changes

@bbielinski-splunk bbielinski-splunk bbielinski-splunk requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mposluszny-splunk mposluszny-splunk

Labels
splunk-supported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mposluszny-splunk @bbielinski-splunk @bb-splunk @splunk-soar-connectors-bot