Merge pull request #17 from splunk-soar-connectors/next

Merging next to main for release 2.3.0

README.md

@@ -2,11 +2,11 @@
 # Tanium REST
 
 Publisher: Splunk  
-Connector Version: 2.2.1  
+Connector Version: 2.3.0  
 Product Vendor: Tanium  
 Product Name: Tanium REST  
 Product Version Supported (regex): ".\*"  
-Minimum Product Version: 5.3.3  
+Minimum Product Version: 6.1.1  
 
 This app supports investigative and generic actions on Tanium
 
@@ -678,7 +678,7 @@ action_result.data.\*.selects.\*.sensor.parameter_definition | string |  |
 action_result.data.\*.selects.\*.sensor.value_type | string |  |   String 
 action_result.data.\*.sensor_references.\*.name | string |  |   Child Processes 
 action_result.data.\*.sensor_references.\*.real_ms_avg | numeric |  |   0 
-action_result.data.\*.sensor_references.\*.start_char | string |  |   4 
+action_result.data.\*.sensor_references.\*.start_char | numeric |  |   4 
 action_result.data.\*.skip_lock_flag | numeric |  |  
 action_result.summary.number_of_parsed_questions | numeric |  |   7 
 action_result.message | string |  |   Num parsed questions: 7 
@@ -930,6 +930,7 @@ action_result.data.\*.package_spec.mod_user.id | numeric |  |   0
 action_result.data.\*.package_spec.mod_user.name | string |  |  
 action_result.data.\*.package_spec.modification_time | string |  |   2001-01-01T00:00:00Z 
 action_result.data.\*.package_spec.name | string |  |   make directory 
+action_result.data.\*.package_spec.parameter_definition | string |  |  
 action_result.data.\*.package_spec.parameters.\*.key | string |  |   $1 
 action_result.data.\*.package_spec.parameters.\*.type | numeric |  |   0 
 action_result.data.\*.package_spec.parameters.\*.value | string |  |   TestDirectory 

release_notes/2.3.0.md

@@ -0,0 +1 @@
+* Bug fix in 'execute action' action [PAPP-33230]

taniumrest.json

@@ -13,13 +13,13 @@
     "fips_compliant": true,
     "license": "Copyright (c) 2019-2024 Splunk Inc.",
     "latest_tested_versions": [
-        "Build (Windows): 7.5.2.3503 | Console: 3.0.64"
+        "Build (Windows): 7.5.4.1158 | Console: 3.2.24"
     ],
-    "app_version": "2.2.1",
-    "utctime_updated": "2022-01-07T20:22:22.000000Z",
+    "app_version": "2.3.0",
+    "utctime_updated": "2022-01-07T20:22:22.000001Z",
     "package_name": "phantom_taniumrest",
     "main_module": "taniumrest_connector.py",
-    "min_phantom_version": "5.3.3",
+    "min_phantom_version": "6.1.1",
     "app_wizard_version": "1.0.0",
     "configuration": {
         "base_url": {
@@ -618,9 +618,9 @@
                 },
                 {
                     "data_path": "action_result.data.*.sensor_references.*.start_char",
-                    "data_type": "string",
+                    "data_type": "numeric",
                     "example_values": [
-                        "4"
+                        4
                     ]
                 },
                 {
@@ -2101,6 +2101,10 @@
                     "column_name": "Package Name",
                     "column_order": 9
                 },
+                {
+                    "data_path": "action_result.data.*.package_spec.parameter_definition",
+                    "data_type": "string"
+                },
                 {
                     "data_path": "action_result.data.*.package_spec.parameters.*.key",
                     "data_type": "string",

taniumrest_connector.py

@@ -535,7 +535,12 @@ def _execute_action_support(self, param, action_result): # noqa: 901
                     "Error while parsing the 'package_parameter' field. Error: {}"
                     .format(error_message))
 
-            if len(package_parameter) != len(parameter_definition.get("parameters")):
+            count_of_params = 0
+            for params in parameter_definition.get('parameters', []):
+                if params.get('parameterType') not in TANIUMREST_PARAMETERS_WITHOUT_INPUT:
+                    count_of_params += 1
+
+            if len(package_parameter) != count_of_params:
                 return action_result.set_status(
                     phantom.APP_ERROR,
                     "Please provide all the required package parameters in 'package_parameter' parameter")
@@ -555,15 +560,15 @@ def _execute_action_support(self, param, action_result): # noqa: 901
                     "The following key(s) are incorrect: {}. Please provide correct key(s)".format(', '.join(invalid_keys)))
 
         data = dict()
-        package_param = dict()
+        package_param = list()
         package_spec = {
             "source_id": package_id
         }
         if package_parameter and parameter_definition and len(parameter_definition.get("parameters")) != 0:
             for parameter_key, parameter_value in list(package_parameter.items()):
-                package_param.update({"key": parameter_key, "value": parameter_value})
+                package_param.append({"key": parameter_key, "value": parameter_value})
 
-            package_spec.update({"parameters": [package_param]})
+            package_spec.update({"parameters": package_param})
 
         if group_name:
             group_as_obj = None

taniumrest_consts.py

@@ -31,6 +31,7 @@
     "[current result unavailable]",
     "[results currently unavailable]"
 ]
+TANIUMREST_PARAMETERS_WITHOUT_INPUT = ("com.tanium.components.parameters::SeparatorParameter",)
 
 # Constants relating to 'get_error_message_from_exception'
 TANIUMREST_ERR_CODE_MSG = "Error code unavailable"