Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: individual support for manual checks and exceptions #84

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat: individual support for manual checks and exceptions #84

wants to merge 37 commits into from

Conversation

truptilangalia-crest
Copy link
Contributor

Following changes have been done as part of this PR

  • Instead of maintaining a single file for manual checks and exception, now action will use two individual files, .appinspect.manual.check and .appinspect.expect
  • Added a validation to check all the expected checks which are mentioned in .appinspect.expect must contain a ticket id starting with ADDON/APPCERT
  • Removed condition for checking manual_check is vetted only when included tag is manual, action will check if manual_check is vetted or not for all the tags
  • Upgraded Appinspect version to the latest available 2.30.0
  • Made enhancements to better represent test report in CI stage for easy understanding

dependabot bot and others added 30 commits December 7, 2022 17:03
@dependabot
chore(deps): bump splunk-appinspect from 2.14.1 to 2.30.0
808f9e8 
Bumps [splunk-appinspect](https://splunk.com) from 2.14.1 to 2.30.0.

---
updated-dependencies:
- dependency-name: splunk-appinspect
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@truptilangalia-crest
test: dockerfile instead of image
ca2f209
@truptilangalia-crest
test: failed action on not vetting entry
67deec7
@truptilangalia-crest
test: resolved issue with failures
4afd00e
@truptilangalia-crest
test: updated conditions for checking vetting file
718b7f5
@truptilangalia-crest
test: fixed an error
49c7d36
@truptilangalia-crest
test: code added for 2 vetting files
b2ae886
@truptilangalia-crest
test: fixed typo in condition
1c00fdb
@truptilangalia-crest
test: markdown for expected failures
439e099
@truptilangalia-crest
test: file open with append mode
376a46c
@truptilangalia-crest
test: testing
b2966f4
@truptilangalia-crest
test: reverted changes
6d8c397
@truptilangalia-crest
test: removed manual tag condition for generating markdown
4bc7bd1
@truptilangalia-crest
test: formated result
954be01
@truptilangalia-crest
test: formatted results
672d040
@truptilangalia-crest
tets: format changed for failures
2cb9f9f
@truptilangalia-crest
test: fixed a typo
b33d646
@truptilangalia-crest
test: warjings added
1c050e5
@truptilangalia-crest
test: validation added for comment
96f0f59
@truptilangalia-crest
test: re imported
0406b25
@truptilangalia-crest
test: fixed a tyopo
2196b6a
@truptilangalia-crest
test: comments added
39926c2
@truptilangalia-crest
test: added checklist
50b70ed
@truptilangalia-crest
test: added list
15724d7
@truptilangalia-crest
test: typo fixed
3ab75c8
@truptilangalia-crest
test: updated file names
bbc3465
@truptilangalia-crest
test: added review comment
2231123
@truptilangalia-crest
test: format related changes
2ce3dad
@truptilangalia-crest
test: removed exttra debug statements
44a2d25
@truptilangalia-crest
test: replaced set-output
8de57d2
@uoboda-splunk
Copy link
Contributor

Please fix pre-commit Fix for Build Action is already there #83 - you should use sudo snap install yq to install yq

uoboda-splunk
uoboda-splunk suggested changes Jan 3, 2023
View reviewed changes
entrypoint.sh Outdated
echo "::endgroup::"
fi

exit "$exit_code"
exit "$(($exit_code_failure_check || $exit_code_manual_check))"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline needed - please fix pre-commit and CI

kkania-splunk
kkania-splunk reviewed Jan 3, 2023
View reviewed changes
action.yml Outdated
required: false
default: ".app-vetting.yaml"
default: ".appinspect.manualcheck"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about keeping .yaml extension in the file name? it's more clear what kind of data is inside

@truptilangalia-crest truptilangalia-crest mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkania-splunk kkania-splunk kkania-splunk left review comments

@uoboda-splunk uoboda-splunk uoboda-splunk requested changes

@nariyanibhargav nariyanibhargav Awaiting requested review from nariyanibhargav

@siddharth-khatsuriya siddharth-khatsuriya Awaiting requested review from siddharth-khatsuriya

@rajkarkar-crest rajkarkar-crest Awaiting requested review from rajkarkar-crest

@harshilgajera-crest harshilgajera-crest Awaiting requested review from harshilgajera-crest

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@truptilangalia-crest @uoboda-splunk @kkania-splunk