-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove feature cim-field-report generation #885
Conversation
What is the reason of moving from |
@kdoroszko-splunk I have moved that test file to actually align that with the submodules. |
Right, thanks for clarifying. |
@dvarasani-crest is Beside above, LGTM! |
@mkolasinski-splunk I have added ! to indicate this PR as a breaking change. Also, since this PR contains a BREAKING change commit, do you still think we need to rebase it to release/5.4.0? because merging this commit to release/5.4.0 would lead to release v6.0.0 when we merge release/5.4.0 to main. |
You are right - let's keep it this way. Regarding base branch - I think we can merge it to develop as there are being aggregated changes for v6.0.0 release as far as I can see: #871 |
Updated base branch to develop. |
🎉 This issue has been resolved in version 5.4.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR removes the feature of generating cim-field-report.
ref: ADDON-73385
NOTE: