Suppress defaults when planning changes to jira service desk params #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in splunk#161, terraform plan shows changes to saved search parameters action_jira_service_desk_param_jira_description and action_jira_service_desk_param_jira_summary when using the defaults for those parameters. From what I can tell, the default values are computed server-side by Splunk. I believe this change will suppress superfluous changes to these Jira parameters, but may break in the future if the Splunk -computed defaults were to change.
|
@rrossetti-splunk would you please review? I believe this will close #161 and reduce meaningless changes in plan/apply output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #161, terraform plan shows changes to saved search parameters
action_jira_service_desk_param_jira_descriptionandaction_jira_service_desk_param_jira_summarywhen using the defaults for those parameters, even when no change is necessary.From what I can tell, the default values are computed server-side by Splunk. In my testing, the changes in this PR suppress superfluous changes to these Jira parameters. This may break in the future if the Splunk-computed defaults were to change.