fix: add proper log message when argo logs yields with EOF error #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-dabro
approved these changes
Sep 9, 2024
srv-rr-github-token
added a commit
that referenced
this pull request
Sep 11, 2024
## [5.0.2](v5.0.1...v5.0.2) (2024-09-11) ### Bug Fixes * add proper log message when argo logs yields with EOF error ([#34](#34)) ([f2ba058](f2ba058))
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides proper log message when the EOF error appears while performing argo logs --follow operation. It caused a lot of confusion among developers, since it looked like the tests stopped being performed (although they were still in progress). The developers used to unnecessarily re-trigger tests in this case.
The message should be enough. Optionally, we could also add one or two retries of argo logs --follow while getting EOF error (https://grpc.github.io/grpc/core/md_doc_statuscodes.html)