Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best-effort error reporting for interactions on final methods #2040

Merged
merged 15 commits into from
Dec 28, 2024

Fix minor things

c148647
Select commit
Loading
Failed to load commit list.
Merged

Best-effort error reporting for interactions on final methods #2040

Fix minor things
c148647
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 28, 2024 in 0s

81.84% (+1.39%) compared to 2c7db77

View this Pull Request on Codecov

81.84% (+1.39%) compared to 2c7db77

Details

Codecov Report

Attention: Patch coverage is 88.18898% with 15 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (2c7db77) to head (c148647).
Report is 179 commits behind head on master.

Files with missing lines Patch % Lines
...untime/extension/builtin/FailsWithInterceptor.java 12.50% 4 Missing and 3 partials ⚠️
...va/org/spockframework/mock/runtime/MockObject.java 71.42% 1 Missing and 3 partials ⚠️
...ock/runtime/ByteBuddyMockInteractionValidator.java 95.74% 1 Missing and 1 partial ⚠️
...ckframework/spring/mock/DelegatingInterceptor.java 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2040      +/-   ##
============================================
+ Coverage     80.44%   81.84%   +1.39%     
- Complexity     4337     4686     +349     
============================================
  Files           441      452      +11     
  Lines         13534    14659    +1125     
  Branches       1707     1845     +138     
============================================
+ Hits          10888    11998    +1110     
+ Misses         2008     1979      -29     
- Partials        638      682      +44
Files with missing lines Coverage Δ
...main/java/org/spockframework/compiler/AstUtil.java 80.13% <ø> (+0.26%) ⬆️
...java/org/spockframework/compiler/SpecRewriter.java 93.91% <100.00%> (+0.21%) ⬆️
...n/java/org/spockframework/compiler/SpockNames.java 0.00% <ø> (ø)
...in/java/org/spockframework/lang/SpecInternals.java 86.86% <100.00%> (+5.85%) ⬆️
...java/org/spockframework/mock/ISpockMockObject.java 100.00% <100.00%> (ø)
.../main/java/org/spockframework/mock/MockNature.java 100.00% <100.00%> (ø)
...rc/main/java/org/spockframework/mock/MockUtil.java 100.00% <100.00%> (ø)
...ork/mock/constraint/EqualMethodNameConstraint.java 100.00% <100.00%> (ø)
...k/mock/constraint/EqualPropertyNameConstraint.java 100.00% <100.00%> (ø)
...ockframework/mock/constraint/TargetConstraint.java 100.00% <100.00%> (+6.66%) ⬆️
... and 12 more

... and 20 files with indirect coverage changes

View more details on Codecov