-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not timeout tests locally #2077
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2077 +/- ##
=========================================
Coverage 81.87% 81.87%
- Complexity 4686 4689 +3
=========================================
Files 452 452
Lines 14656 14656
Branches 1845 1845
=========================================
Hits 12000 12000
Misses 1976 1976
Partials 680 680 |
timeout = Duration.ofMinutes(15) | ||
// But only on CI or longer needing debug sessions get killed by the timeout. | ||
if (isCiServer) { | ||
timeout = Duration.ofMinutes(15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add debug detection to the timeout extension instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used debug detections in the past and they only work semi-reliably from my experience.
But I also think it is not the right way, but like I did.
My box was occupied with other stuff and at the same time doing a full check
on Spock and the 15 minutes were busted even without debugging. I don't see any reason to have that limit locally, you can at any time abort the build manually easily if you see it hangs.
No description provided.