Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not timeout tests locally #2077

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Jan 8, 2025

No description provided.

Copy link
Member Author

Vampire commented Jan 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (8017fc3) to head (7fdbddf).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2077   +/-   ##
=========================================
  Coverage     81.87%   81.87%           
- Complexity     4686     4689    +3     
=========================================
  Files           452      452           
  Lines         14656    14656           
  Branches       1845     1845           
=========================================
  Hits          12000    12000           
  Misses         1976     1976           
  Partials        680      680           

@Vampire Vampire requested a review from leonard84 January 8, 2025 16:53
timeout = Duration.ofMinutes(15)
// But only on CI or longer needing debug sessions get killed by the timeout.
if (isCiServer) {
timeout = Duration.ofMinutes(15)
Copy link
Member

@leonard84 leonard84 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used debug detections in the past and they only work semi-reliably from my experience.

But I also think it is not the right way, but like I did.

My box was occupied with other stuff and at the same time doing a full check on Spock and the 15 minutes were busted even without debugging. I don't see any reason to have that limit locally, you can at any time abort the build manually easily if you see it hangs.

@leonard84 leonard84 enabled auto-merge (squash) January 12, 2025 15:24
@leonard84 leonard84 merged commit f7204d4 into master Jan 12, 2025
52 checks passed
@leonard84 leonard84 deleted the vampire/do-not-timeout-tests-locally branch January 12, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants