Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play by play for data 2013 and before #5

Open
rchanks opened this issue Apr 15, 2021 · 1 comment · Fixed by #24
Open

Play by play for data 2013 and before #5

rchanks opened this issue Apr 15, 2021 · 1 comment · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@rchanks
Copy link

rchanks commented Apr 15, 2021

Describe the bug
When using the cfbd_pbp_data for any data before 2014, I am getting errors.

When running the following:
Input:
tmp <- tibble()
wk <- 3
seas <- "regular"
yr <- 2013
tmp <- cfbd_pbp_data(yr, seas, wk, team = NULL, play_type = NULL, epa_wpa = TRUE), it returns the following error:

Error:
Error in predict.nnet(object, X) : missing values in 'x'
In addition: Warning messages:
1: In log(dat$new_distance[neg_distance]) : NaNs produced
2: In log(dat$new_distance[neg_distance]) : NaNs produced
3: In log(dat$new_distance[neg_distance]) : NaNs produced
4: In log(dat$new_distance[neg_distance]) : NaNs produced
5: In log(dat$new_distance[neg_distance]) : NaNs produced
6: In log(dat$new_distance[neg_distance]) : NaNs produced

Sometimes another error is produced:
Input:
tmp <- tibble()
wk <- 1
seas <- "regular"
yr <- 2012
tmp <- cfbd_pbp_data(yr, seas, wk, team = NULL, play_type = NULL, epa_wpa = TRUE)

Error:
Error in predict.nnet(object, X) : missing values in 'x'
In addition: There were 20 warnings (use warnings() to see them)

@saiemgilani
Copy link
Collaborator

Thanks for bringing it up, but this is a known issue. I am working on a fix to get all the data going back to the start. Will not be forever but another week or two.

@saiemgilani saiemgilani added the bug Something isn't working label Apr 15, 2021
@saiemgilani saiemgilani self-assigned this Apr 15, 2021
@saiemgilani saiemgilani linked a pull request Jun 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants